Skip to content

Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating #35873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating #35873

wants to merge 3 commits into from

Conversation

ferferga
Copy link

This Pull Request changes the use of PRAGMA foreign_keys in SQLite migrations to PRAGMA defer_foreign_keys, which are allowed inside transactionss without any issue.

It's one of the possible fixes for #35871, and I think the best one, since we will use the exact pragma that SQLite wants to be used for transactions, instead of working around it.

I did my best attempt to update the tests as well, but not sure this is how I should do it (since I didn't see any mention to BEGIN TRANSACTION inside the generated SQL in tests.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@ferferga
Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when…
19ee6d5 
… migrating

defer_foreign_keys is specifically tailored to be used inside
SQLite transactions.

Reference issue: dotnet#35871
@ferferga ferferga requested a review from a team as a code owner March 30, 2025 20:48
@ferferga ferferga mentioned this pull request Mar 30, 2025
Open
@ferferga
Copy link
Author

@dotnet-policy-service agree

@roji roji requested a review from cincuranet March 30, 2025 21:42
@cincuranet cincuranet linked an issue Sep 10, 2025 that may be closed by this pull request
Internal PRAGMA foreign_check = 0; commands for SQLite migrations are triggering NonTransactionalMigrationOperationWarning #35871
Open
cincuranet
cincuranet requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks.

@ferferga ferferga requested a review from cincuranet September 17, 2025 23:35
@ferferga
Copy link
Author

ferferga commented Sep 19, 2025 •
edited
Loading

Removing the explicit SupressTransaction seems to have tripped the tests for some reason 😅

@cincuranet
Copy link
Contributor

Yeah. It made tests very angry. :)

@cincuranet
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cincuranet
Copy link
Contributor

Tests Alter_column_remove_autoincrement and Replace_string_primary_key_with_autoincrement_identity don't have updated SQL and still use PRAGMA foreign_keys = 0;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet Awaiting requested review from cincuranet

Requested changes must be addressed to merge this pull request.

Assignees

@cincuranet cincuranet

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal PRAGMA foreign_check = 0; commands for SQLite migrations are triggering NonTransactionalMigrationOperationWarning
3 participants
@ferferga @cincuranet @AndriySvyryd